Check out Grant Acedrex, our featured variant for April, 2024.


[ Help | Earliest Comments | Latest Comments ]
[ List All Subjects of Discussion | Create New Subject of Discussion ]
[ List Earliest Comments Only For Pages | Games | Rated Pages | Rated Games | Subjects of Discussion ]

Comments/Ratings for a Single Item

Earlier Reverse Order Later
bugs[Subject Thread] [Add Response]
Ben Reiniger wrote on Tue, Mar 1, 2022 04:26 PM UTC:

The links to favorites are sometimes populated with just chessvariants.com/rules/. I didn't notice this on the overall favorites listing page, but did on the Games->YourFavorites menu and my personal information page's listing, in both places TessChess (among others) failing to link correctly.


🕸Fergus Duniho wrote on Tue, Mar 1, 2022 05:35 PM UTC:

I was merging the functionality of canonicalURI, which takes an ItemID, into make_link_url, which takes a row, and I didn't do a thorough job of it. That is now fixed. Instead of duplicating functionality, canonicalURI will now use the ItemID to get a row with which it can call make_link_url. Having make_link_url call canonicalURI, as it was doing before, was wasteful, because it queried the database for a row it already had from a previous database query.


Ben Reiniger wrote on Thu, Mar 3, 2022 05:11 PM UTC in reply to Fergus Duniho from Tue Mar 1 05:35 PM:

Bn Em points out a similar issue with link pages in this comment.


🕸Fergus Duniho wrote on Fri, Mar 4, 2022 05:40 PM UTC in reply to Ben Reiniger from Thu Mar 3 05:11 PM:

Okay, that's now fixed.


4 comments displayed

Earlier Reverse Order Later

Permalink to the exact comments currently displayed.